Skip to content

Add Valid Parentheses Checker algorithm #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add Valid Parentheses Checker algorithm #512

wants to merge 3 commits into from

Conversation

Jccqt
Copy link
Contributor

@Jccqt Jccqt commented Jul 11, 2025

Summary of the Change:

This pull request introduces the Valid Parentheses Checker, which checks whether the given parentheses are valid. A valid parentheses should have opening braces and closing braces.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

Jccqt added 3 commits July 12, 2025 06:49
@Jccqt
Add Valid Parentheses Checker algorithm
bc160b4
@Jccqt
Added more test cases for ValidParenthesesTests.cs
a2c5d5d 
Refactored nested if-else to switch-case in ValidParentheses.cs
@Jccqt
Added additional test cases for ValidParenthesesTests.cs
abf73c9 
Refactored switch-case to dictionary in ValidParentheses.cs
@Jccqt Jccqt requested a review from siriak as a code owner July 11, 2025 23:28
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.17%. Comparing base (8fec042) to head (abf73c9).

Files with missing lines Patch % Lines
Algorithms/Strings/ValidParentheses.cs 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   95.18%   95.17%   -0.01%     
==========================================
  Files         269      270       +1     
  Lines       10894    10922      +28     
  Branches     1531     1536       +5     
==========================================
+ Hits        10369    10395      +26     
  Misses        400      400              
- Partials      125      127       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siriak
Copy link
Member

siriak commented Jul 13, 2025

It's already implemented here

C-Sharp/Algorithms/Stack/BalancedParenthesesChecker.cs

Line 10 in 8fec042

public class BalancedParenthesesChecker

@siriak siriak closed this Jul 13, 2025
@Jccqt
Copy link
Contributor Author

Jccqt commented Jul 13, 2025

I see, sorry bro my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak Awaiting requested review from siriak siriak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jccqt @siriak